Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Input is lost upon opening search page #8535

Merged
merged 14 commits into from
Apr 21, 2022
Merged

Fix Input is lost upon opening search page #8535

merged 14 commits into from
Apr 21, 2022

Conversation

rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Apr 7, 2022

Details

All details here: #6069 (comment)

Gist: Autofocus on TextInput breaks the animation because the browser scrolls to the TextInput!
Making the card's position: fixed solves this problem. However, mobile doesn't support position of type fixed. So a create a native file is created which uses the old implementation.

Fixed Issues

$ #6069

Tests

  1. Sign into New Dot with any account
  2. Press ⌘K to open the search view and immediately start typing
  3. Verify that all of the text you have typed is captured.
  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

  1. Sign into New Dot with any account
  2. Press ⌘K to open the search view and immediately start typing
  3. Verify that all of the text you have typed is captured.
  4. Verify that other RHN screens don't have any regressions.
  • Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-04-10.at.9.55.26.PM.mov

Mobile Web - Safari

Screen.Recording.2022-04-10.at.10.24.14.PM.mov

Mobile Web - Chrome (Android)

screen-20220410-223315.mp4

Desktop

Screen.Recording.2022-04-10.at.10.35.55.PM.mov

iOS

Screen.Recording.2022-04-10.at.10.17.09.PM.mov

Android

screen-20220410-223315.mp4

@rushatgabhane rushatgabhane changed the title Fix Input is lost upon opening search page [WIP] Fix Input is lost upon opening search page Apr 7, 2022
@rushatgabhane
Copy link
Member Author

rushatgabhane commented Apr 7, 2022

I'm not sure why Marc was requested for a review in a draft PR. (I'm guessing it's because I'm modifying Navigation related files)

@rushatgabhane
Copy link
Member Author

Unrelated console error
Reported on slack here - https://expensify.slack.com/archives/C01GTK53T8Q/p1649611541508959

image

@rushatgabhane rushatgabhane changed the title [WIP] Fix Input is lost upon opening search page Fix Input is lost upon opening search page Apr 10, 2022
@rushatgabhane rushatgabhane marked this pull request as ready for review April 10, 2022 19:01
@rushatgabhane rushatgabhane requested review from marcaaron and a team as code owners April 10, 2022 19:01
@melvin-bot melvin-bot bot requested review from Luke9389 and a team and removed request for a team April 10, 2022 19:01
},
},
cardStyle,
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

observation: This code is mostly the same with the non native version of the file
suggestion: If we need a more specific style passed on one platform then have getCardStyle() return different things depending on the platform rather than create two very similar versions of the same code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@marcaaron
Copy link
Contributor

I'm not sure why Marc was requested for a review in a draft PR. (I'm guessing it's because I'm modifying Navigation related files)

Pretty much that. 😄 I am keeping tabs on a few areas of interest to me. Mostly so I can stay current on the code but also to offer assistance with any areas that might be confusing.

@rushatgabhane
Copy link
Member Author

Mostly so I can stay current on the code but also to offer assistance with any areas that might be confusing

That's interesting. Gotta love github to make this possible and so simple.


@Luke9389 all yours!

@Luke9389
Copy link
Contributor

checkin this out now...

Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests well. Thanks

@Luke9389 Luke9389 dismissed marcaaron’s stale review April 21, 2022 23:32

Suggestion was implemented

@Luke9389 Luke9389 merged commit 32d8f02 into Expensify:main Apr 21, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.1.57-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mallenexpensify mallenexpensify changed the title Fix Input is lost upon opening search page [Pay on 5/20] Fix Input is lost upon opening search page May 18, 2022
@mallenexpensify
Copy link
Contributor

Updated title to remind to pay on 5/20 if no regressions

@mallenexpensify
Copy link
Contributor

d'oh.. this is the PR and not the actual issue :)
:ohnothing:

@mallenexpensify mallenexpensify changed the title [Pay on 5/20] Fix Input is lost upon opening search page Fix Input is lost upon opening search page May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants